fix: not owned stream count #13030
Merged
fix: not owned stream count #13030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… otherwise when recalculating job updates ownedStreamCount and not owned streams are actually flushed, the counter will contain wrong value because it's decremented every time the stream is flushed. Signed-off-by: Vladyslav Diachenko <vlad.diachenko@grafana.com>
vlad-diachenko
changed the title
This was referenced May 27, 2024
7 tasks
This was referenced Jun 10, 2024
7 tasks
This was referenced Jul 3, 2024
Closed
JordanRushing
added a commit
to JordanRushing/loki
that referenced
this pull request
Jul 15, 2024
Ingester stream limits now take into account "owned streams" and periodically update when the Ingester ring is changed. Non-owned streams are now also flushed when this update takes place. The stream limit calculation has also been updated for improved accuracy in multi-zone ingester deployments. Relevant PRs: - grafana#13006 - grafana#13030 - grafana#13232 - grafana#13103 - grafana#13231 - grafana#13254 - grafana#13314 - grafana#13321
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
added an additional field to track the count of not-owned streams count, otherwise when recalculating job updates ownedStreamCount and not-owned streams are actually flushed, and the counter will contain the wrong value because it's decremented every time the stream is flushed.