diff --git a/Makefile b/Makefile index 04e143fae13..a0bbb58c4d5 100644 --- a/Makefile +++ b/Makefile @@ -329,7 +329,7 @@ lint: check-makefiles faillint -paths "github.com/grafana/mimir/pkg/..." ./pkg/alertmanager/alertspb/... faillint -paths "github.com/grafana/mimir/pkg/..." ./pkg/ruler/rulespb/... faillint -paths "github.com/grafana/mimir/pkg/..." ./pkg/storage/sharding/... - faillint -paths "github.com/grafana/mimir/pkg/..." ./pkg/querier/engine/... + faillint -paths "github.com/grafana/mimir/pkg/..." ./pkg/querier/engine/common/... faillint -paths "github.com/grafana/mimir/pkg/..." ./pkg/querier/api/... faillint -paths "github.com/grafana/mimir/pkg/..." ./pkg/util/globalerror diff --git a/pkg/mimir/modules.go b/pkg/mimir/modules.go index 39be11a7f58..a3c63dbaf89 100644 --- a/pkg/mimir/modules.go +++ b/pkg/mimir/modules.go @@ -9,6 +9,7 @@ import ( "context" "flag" "fmt" + "github.com/grafana/mimir/pkg/querier/engine/common" "net/http" "strconv" "time" @@ -47,7 +48,6 @@ import ( "github.com/grafana/mimir/pkg/frontend/transport" "github.com/grafana/mimir/pkg/ingester" "github.com/grafana/mimir/pkg/querier" - "github.com/grafana/mimir/pkg/querier/engine" "github.com/grafana/mimir/pkg/querier/tenantfederation" querier_worker "github.com/grafana/mimir/pkg/querier/worker" "github.com/grafana/mimir/pkg/ruler" @@ -712,7 +712,7 @@ func (t *Mimir) initQueryFrontendTripperware() (serv services.Service, err error t.QueryFrontendCodec = querymiddleware.NewPrometheusCodec(t.Registerer, t.Cfg.Frontend.QueryMiddleware.QueryResultResponseFormat) promqlEngineRegisterer := prometheus.WrapRegistererWith(prometheus.Labels{"engine": "query-frontend"}, t.Registerer) - engineOpts, engineExperimentalFunctionsEnabled := engine.NewPromQLEngineOptions(t.Cfg.Querier.EngineConfig, t.ActivityTracker, util_log.Logger, promqlEngineRegisterer) + engineOpts, engineExperimentalFunctionsEnabled := common.NewPromQLEngineOptions(t.Cfg.Querier.EngineConfig, t.ActivityTracker, util_log.Logger, promqlEngineRegisterer) tripperware, err := querymiddleware.NewTripperware( t.Cfg.Frontend.QueryMiddleware, diff --git a/pkg/querier/engine/config.go b/pkg/querier/engine/common/config.go similarity index 99% rename from pkg/querier/engine/config.go rename to pkg/querier/engine/common/config.go index 5a116a2726a..4aaac2583e8 100644 --- a/pkg/querier/engine/config.go +++ b/pkg/querier/engine/common/config.go @@ -1,6 +1,6 @@ // SPDX-License-Identifier: AGPL-3.0-only -package engine +package common import ( "flag" diff --git a/pkg/querier/engine/query_tracker.go b/pkg/querier/engine/common/query_tracker.go similarity index 99% rename from pkg/querier/engine/query_tracker.go rename to pkg/querier/engine/common/query_tracker.go index 85827b46a92..d4a0aac7b35 100644 --- a/pkg/querier/engine/query_tracker.go +++ b/pkg/querier/engine/common/query_tracker.go @@ -1,6 +1,6 @@ // SPDX-License-Identifier: AGPL-3.0-only -package engine +package common import ( "bytes" diff --git a/pkg/querier/engine/query_tracker_test.go b/pkg/querier/engine/common/query_tracker_test.go similarity index 99% rename from pkg/querier/engine/query_tracker_test.go rename to pkg/querier/engine/common/query_tracker_test.go index ad24fa70b9c..e9d04119a44 100644 --- a/pkg/querier/engine/query_tracker_test.go +++ b/pkg/querier/engine/common/query_tracker_test.go @@ -1,6 +1,6 @@ // SPDX-License-Identifier: AGPL-3.0-only -package engine +package common import ( "context" diff --git a/pkg/querier/querier.go b/pkg/querier/querier.go index a4c34c8a2e4..f54ae0ca0e5 100644 --- a/pkg/querier/querier.go +++ b/pkg/querier/querier.go @@ -10,6 +10,7 @@ import ( "errors" "flag" "fmt" + "github.com/grafana/mimir/pkg/querier/engine/common" "sync" "time" @@ -25,7 +26,6 @@ import ( "github.com/prometheus/prometheus/util/annotations" "golang.org/x/sync/errgroup" - "github.com/grafana/mimir/pkg/querier/engine" "github.com/grafana/mimir/pkg/querier/engine/streaming" "github.com/grafana/mimir/pkg/querier/stats" "github.com/grafana/mimir/pkg/storage/chunk" @@ -59,7 +59,7 @@ type Config struct { PromQLEngine string `yaml:"promql_engine" category:"experimental"` // PromQL engine config. - EngineConfig engine.Config `yaml:",inline"` + EngineConfig common.Config `yaml:",inline"` } const ( @@ -150,7 +150,7 @@ func New(cfg Config, limits *validation.Overrides, distributor Distributor, stor return lazyquery.NewLazyQuerier(querier), nil }) - opts, engineExperimentalFunctionsEnabled := engine.NewPromQLEngineOptions(cfg.EngineConfig, tracker, logger, reg) + opts, engineExperimentalFunctionsEnabled := common.NewPromQLEngineOptions(cfg.EngineConfig, tracker, logger, reg) // Experimental functions can only be enabled globally, and not on a per-engine basis. parser.EnableExperimentalFunctions = engineExperimentalFunctionsEnabled