From ec15d48f82f27e284aad348a2e2cc77f45c6dcc2 Mon Sep 17 00:00:00 2001 From: Marco Pracucci Date: Tue, 8 Oct 2024 03:48:00 -0400 Subject: [PATCH] Log Ingester.LabelNames() matchers in traces (#9544) Signed-off-by: Marco Pracucci --- pkg/ingester/ingester.go | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/pkg/ingester/ingester.go b/pkg/ingester/ingester.go index b636319723..4adc37929e 100644 --- a/pkg/ingester/ingester.go +++ b/pkg/ingester/ingester.go @@ -1741,6 +1741,9 @@ func (i *Ingester) LabelNames(ctx context.Context, req *client.LabelNamesRequest } defer func() { finishReadRequest(err) }() + spanlog, ctx := spanlogger.NewWithLogger(ctx, i.logger, "Ingester.LabelNames") + defer spanlog.Finish() + userID, err := tenant.TenantID(ctx) if err != nil { return nil, err @@ -1768,6 +1771,9 @@ func (i *Ingester) LabelNames(ctx context.Context, req *client.LabelNamesRequest } defer q.Close() + // Log the actual matchers passed down to TSDB. This can be useful for troubleshooting purposes. + spanlog.DebugLog("num_matchers", len(matchers), "matchers", util.LabelMatchersToString(matchers)) + hints := &storage.LabelHints{} names, _, err := q.LabelNames(ctx, hints, matchers...) if err != nil {