Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove -ruler.query-frontend.timeout and use -querier.timeout instead #2129

Closed
pracucci opened this issue Jun 17, 2022 · 2 comments · Fixed by #2222
Closed

Remove -ruler.query-frontend.timeout and use -querier.timeout instead #2129

pracucci opened this issue Jun 17, 2022 · 2 comments · Fixed by #2222
Assignees

Comments

@pracucci
Copy link
Collaborator

#2090 introduced -ruler.query-frontend.timeout. We're trying to reduce config options, so an alternative option could be reusing -querier.timeout, documenting that needs to be set for ruler too when remote rule evaluation is used. We already use -querier.timeout in query-frontend too.

@pstibrany
Copy link
Member

I think we should fix this before 2.2 release, so that we don't release new flag (-ruler.query-frontend.timeout) to the world.

@stevesg
Copy link
Contributor

stevesg commented Jun 24, 2022

Doing it now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants