Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move purger API endpoint to another component #2190

Closed
wilfriedroset opened this issue Jun 23, 2022 · 1 comment · Fixed by #2644
Closed

Move purger API endpoint to another component #2190

wilfriedroset opened this issue Jun 23, 2022 · 1 comment · Fixed by #2644

Comments

@wilfriedroset
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

The component "purger" is only responsible for exposing 2 API endpoints. When called mimir will upload a marker in the bucket which will ultimately trigger the purge of the data. Apart from this the purger does nothing else.

Describe the solution you'd like

Migrate the purger to another component, the compactor for example.

Describe alternatives you've considered

To achieve the same behavior we could enable the module along with another one

target: compactor,purger

Additional context

In a not monolithic deployment this help save resource (pod or instance)
General idea come from slack channel: https://grafana.slack.com/archives/C039863E8P7/p1655914578345719

@pracucci
Copy link
Collaborator

I agree compactor is a good component to host the purger API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants