Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus lookback_delta parameter in instant and range query API #4463

Open
duricanikolic opened this issue Mar 10, 2023 · 3 comments
Open
Labels
enhancement New feature or request

Comments

@duricanikolic
Copy link
Contributor

In this commit prometheus has added the lookback_delta parameter to the instant and range query API. In order to be prometheus compatible, mimir should support this new feature too. The goal of this issue is to discuss whether this should be done, and if the decision is affirmative, implement it.

@pracucci
Copy link
Collaborator

I haven't checked the changes required to support it, but I think at least we should support it in the query-frontend, and then propagate it to every partial query pushed down to queriers.

@shichanglin5
Copy link

In this commit prometheus has added the lookback_delta parameter to the instant and range query API. In order to be prometheus compatible, mimir should support this new feature too. The goal of this issue is to discuss whether this should be done, and if the decision is affirmative, implement it.

There is indeed a problem with this commit. It does not pass the lookback_delta down (for example, when querying ingester), so it does not work properly.

@shichanglin5
Copy link

I haven't checked the changes required to support it, but I think at least we should support it in the query-frontend, and then propagate it to every partial query pushed down to queriers.

Why is it not supported? The data of different tenants is independent, and the interval of writing samples may be different, resulting in problems for different tenants to use the same lookback_delta.

Please reconsider this requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants