Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: grafana/tanka
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 49f0e180b6fc842fd6fdf543774a02fddaaf69c5
Choose a base ref
...
head repository: grafana/tanka
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: e27e7b48b6d23786191393c661e9d6ade7768c10
Choose a head ref
  • 8 commits
  • 7 files changed
  • 4 contributors

Commits on Feb 20, 2020

  1. fix(docs): typos (#219)

    @jcalonso
    jcalonso authored Feb 20, 2020
    Configuration menu
    Copy the full SHA
    ee0e288 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2020

  1. fix(kubernetes): Randomize nsPatch file name (#225)

    @robert-milan
    robert-milan authored Feb 27, 2020
    Configuration menu
    Copy the full SHA
    cd84c7c View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2020

  1. Allow overriding kubectl path using env var. 

    Up to now, Tanka was using hard-coded string as a `kubectl` path, making
it hard to do any other tool without playing tricks with $PATH. This
commit allows to use TANKA_KUBECTL_PATH env variable to override the
path to `kubectl` used in Tanka's code.

See also #220 .

Signed-off-by: Milan Plzik <milan.plzik@grafana.com>
    @mplzik @sh0rez
    mplzik authored and sh0rez committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    3d60f10 View commit details
    Browse the repository at this point in the history

  2. Refactor KubectlPath to KubectlCmd. 

    As suggested in PR review, let's turn the `KubectlPath` into an actual
function that returns exec.Command object.

Signed-off-by: Milan Plzik <milan.plzik@grafana.com>
    @mplzik @sh0rez
    mplzik authored and sh0rez committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    f992bdb View commit details
    Browse the repository at this point in the history

  3. Add documenation listing supported env variables. 

    Signed-off-by: Milan Plzik <milan.plzik@grafana.com>
    @mplzik @sh0rez
    mplzik authored and sh0rez committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    c2e84dd View commit details
    Browse the repository at this point in the history

  4. Fix code review comments. 

    * `kubectlCmd` is only used within `client` package, no need for it to be
  public.
* Nicer formatting of the environment variable documentation.

Signed-off-by: Milan Plzik <milan.plzik@grafana.com>
    @mplzik @sh0rez
    mplzik authored and sh0rez committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    cef5a4f View commit details
    Browse the repository at this point in the history

  5. doc: Formatting nits

    @sh0rez
    sh0rez committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    68e83c4 View commit details
    Browse the repository at this point in the history

  6. fix(kubernetes): properly call kubectl in delete

    @sh0rez
    sh0rez committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    e27e7b4 View commit details
    Browse the repository at this point in the history
Loading