fix(kubernetes): correct handling of kubectl stderr #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always shows stderr from kubectl in case an error occurs
sh0rez
added
kind/bug
tomwilkie
approved these changes
Aug 25, 2019
|
Since we'll be removing that stderr string altogether, I want to make sure you guys are aware before 1.18 is released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A more sophisticated approach on #59 than #60 took.
Uses a custom regex middleware for the stderr stream to mute all
exit status NUMBERoutputs from kubectl in diff mode, but retains all other outputs.Furthermore fixes a minor bug in error handling where a missing object was always reported as a
secret.Fixes #59
Closes #60