Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kubernetes): diff histogram #67

Merged
merged 1 commit into from
Sep 4, 2019
Merged

feat(kubernetes): diff histogram #67

merged 1 commit into from
Sep 4, 2019

Conversation

sh0rez
Copy link
Member

@sh0rez sh0rez commented Aug 28, 2019

Adds a --summarize / -s flag to tk diff, to automatically pipe the output
of diff(1) through diffstat(1) to generate a histogram of the changes, just
as git sometimes does.

Result:

 extensions.v1beta1.DaemonSet.default.promtail                  |   97 +++
 rbac.authorization.k8s.io.v1beta1.ClusterRole..promtail        |   20
 rbac.authorization.k8s.io.v1beta1.ClusterRoleBinding..promtail |   15
 v1.ConfigMap.default.promtail                                  |  260 ++++++++++
 v1.Namespace..loki                                             |   12
 v1.ServiceAccount.default.promtail                             |    8
 6 files changed, 412 insertions(+)

Fixes #66

@sh0rez
feat(kubernetes): diff histogram
56b115a 
Adds a `--summarize` / `-s` flag to `tk diff`, to automatically pipe the output
of `diff(1)` through `diffstat(1)` to generate a histogram for the changes, just
as git sometimes does.
@sh0rez sh0rez added kind/feature Something new should be added component/cli Command Line Interface component/kubernetes Working with Kubernetes clusters labels Aug 28, 2019
@sh0rez sh0rez added this to the 0.4.0 milestone Aug 28, 2019
@sh0rez sh0rez self-assigned this Aug 28, 2019
slim-bean
slim-bean approved these changes Sep 4, 2019
View reviewed changes
Copy link
Contributor

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sh0rez sh0rez merged commit 832fedb into master Sep 4, 2019
@sh0rez sh0rez deleted the diffstat branch September 4, 2019 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slim-bean slim-bean slim-bean approved these changes

@tomwilkie tomwilkie Awaiting requested review from tomwilkie

@malcolmholmes malcolmholmes Awaiting requested review from malcolmholmes

@gouthamve gouthamve Awaiting requested review from gouthamve

Assignees

@sh0rez sh0rez

Labels
component/cli Command Line Interface component/kubernetes Working with Kubernetes clusters kind/feature Something new should be added
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.

abbreviated diff strategy
2 participants
@sh0rez @slim-bean