Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move loading of custom HTML headers and static assets #49

Merged

Conversation

poettig
Copy link
Contributor

@poettig poettig commented Oct 23, 2023

This change is necessary for greenpau/caddy-security#290, further explanation over there.

It loads custom HTML headers and static assets at the same time that custom js path and custom css path get loaded instead of arbitrarily loading them when reading the Caddyfile in caddy-security.

@greenpau
Copy link
Owner

greenpau commented Dec 2, 2023

Copy link
Contributor

github-actions bot commented Dec 2, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@greenpau
Copy link
Owner

greenpau commented Dec 2, 2023

@poettig , please see here how to agree to CLA. https://github.com/contributor-assistant/github-action#demo-for-step-2-and-3

@poettig poettig force-pushed the move-asset-and-custom-header-loading branch from 76de1e7 to f2a090f Compare December 2, 2023 23:59
@poettig
Copy link
Contributor Author

poettig commented Dec 2, 2023

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Dec 2, 2023
@poettig
Copy link
Contributor Author

poettig commented Dec 3, 2023

@greenpau Sorry, I overlooked the CONTRIBUTING.md and then had to clean up / rebase with upstream on this branch first. It should be all cleared up now :)

@greenpau
Copy link
Owner

greenpau commented Dec 3, 2023

@poettig , please follow https://github.com/greenpau/go-authcrunch/blob/main/CONTRIBUTING.md#contributor-license-agreements. 2 requirements. Apologies for the confusion.

Once it is done, I will merge and release go-authcrunch and update caddy-security accordingly.

@poettig
Copy link
Contributor Author

poettig commented Dec 3, 2023

@greenpau No worries, I should have read CONTRIBUTING.md again after rebasing. I followed the steps and added my consent to the yml.

@greenpau greenpau merged commit 2ff7fcd into greenpau:main Dec 3, 2023
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2023
@greenpau
Copy link
Owner

greenpau commented Dec 3, 2023

@poettig , thank you for contributing 👍

@poettig poettig deleted the move-asset-and-custom-header-loading branch December 3, 2023 00:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants