Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLAlchemy 2.0 not supported #162

Closed
iloveitaly opened this issue Aug 14, 2023 · 7 comments · Fixed by #1000
Closed

SQLAlchemy 2.0 not supported #162

iloveitaly opened this issue Aug 14, 2023 · 7 comments · Fixed by #1000
Labels
enhancement New feature or request

Comments

@iloveitaly
Copy link

Describe the bug
Getting this error from poetry when attempting to add griptape to an existing sqlalchemy project

Using version ^0.14.7 for griptape
Using version ^0.16.3 for griptape-tools

Updating dependencies
Resolving dependencies... (0.3s)

Because griptape (0.14.7) depends on sqlalchemy (>=1.0,<2.0)
 and no versions of griptape match >0.14.7,<0.15.0, griptape (>=0.14.7,<0.15.0) requires sqlalchemy (>=1.0,<2.0).
So, because good-ads depends on both sqlalchemy (^2.0.19) and griptape (^0.14.7), version solving failed.

To Reproduce

poetry add griptape griptape-tools

Expected behavior
Install griptape

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: macOS
  • Version 13.3.1

Additional context
Add any other context about the problem here.

@iloveitaly iloveitaly added the bug Something isn't working label Aug 14, 2023
@vasinov
Copy link
Member

vasinov commented Aug 16, 2023

@iloveitaly, hey Mike! 😄

We are currently relying on some sqlalchemy 1.x-specific functionality but we should definitely upgrade to 2.x. Thanks for bringing this up!

@iloveitaly
Copy link
Author

@vasinov good to finally work with you on something :)

Yeah, totally makes sense. The trick is it prevents any sqlalchemy 2.0 projects from using griptape. If the 1.x functionality is optional if you aren't using any persistence-related functionality, that would be even better.

@vasinov vasinov added enhancement New feature or request bug Something isn't working and removed bug Something isn't working enhancement New feature or request labels Aug 19, 2023
@collindutter collindutter added enhancement New feature or request and removed bug Something isn't working labels Sep 21, 2023
@mattgiles
Copy link

This is an obstacle to adoption for me.

Curious what 1.x functionality is being relied upon / if you would accept a pull request for this work.

@vasinov
Copy link
Member

vasinov commented Nov 11, 2023

@mattgiles, 1.x is used in a handful of classes but the most significant blocker is in SqlDriver.get_table_schema(). Not a terribly hard migration but we just haven't gotten to it yet. If you'd like to submit a PR it would be most appreciated. Thanks!

@mattgiles
Copy link

@vasinov looks totally doable. I started down the path, but believe this issue is blocked by snowflake-sqlalchemry here. Hopefully they can figure that out.

@vasinov
Copy link
Member

vasinov commented Nov 13, 2023

@mattgiles, ah, yes. that's another blocker that I forgot about.

@collindutter
Copy link
Member

snowflakedb/snowflake-sqlalchemy#469 was finally merged, hopefully they make a release soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants