Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add separate gRPC-Web test build job #1137

Merged
merged 2 commits into from
Dec 3, 2020
Merged

Add separate gRPC-Web test build job #1137

merged 2 commits into from
Dec 3, 2020

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Dec 2, 2020 •
edited
Loading

Fixes #886

@JamesNK
Copy link
Member Author

JamesNK commented Dec 2, 2020

@jtattermusch Please make the new grpc_web job required.

jtattermusch
jtattermusch approved these changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@jtattermusch jtattermusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@JamesNK JamesNK merged commit 543ee70 into grpc:master Dec 3, 2020
@JamesNK JamesNK deleted the jamesnk/build-grpcweb branch December 3, 2020 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JunTaoLuo JunTaoLuo JunTaoLuo approved these changes

@jtattermusch jtattermusch jtattermusch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run grpcweb_interoptests.sh tests separately
3 participants
@JamesNK @JunTaoLuo @jtattermusch