-
Notifications
You must be signed in to change notification settings - Fork 768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update development infrastructure #205
Conversation
Co-Authored-By: JunTaoLuo <johluo@microsoft.com>
Hmm need to update https://github.com/grpc/grpc/blame/master/tools/dockerfile/interoptest/grpc_interop_aspnetcore/build_interop.sh#L27-L32 to fix the interop tests. |
Interop test is not required. I think there just needs to be an approval. |
Looks like this has broken the interop test build on grpc/grpc repository: grpc/grpc#18431 |
I might have spoken too soon - I didn't notice grpc/grpc#18714 earlier. But we should have synced more around merging this PR (and subsequently breaking grpc/grpc) anyway. |
Sorry for creating issues with this PR. We underestimated the impact of changing the build in other places. I think for now we'll always get your approval before merging, except if the PR has low risk/impact changes such as:
Does that sound good to you? |
SGTM. |
Addresses #175. Most of the infrastructure is taken from aspnet/AspNetCore.
The get-dotnet.ps1/sh will now install locally to {repoRoot}.dotnet/ and the activate.sh/ps1 will set the appropriate environment variables to use the installed SDK. Edited README to reflect the new workflow.