Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add header to distiguish between grpc streams and others #152

Closed
acasajus opened this issue Mar 9, 2015 · 2 comments
Closed

Add header to distiguish between grpc streams and others #152

acasajus opened this issue Mar 9, 2015 · 2 comments

Comments

@acasajus
Copy link

acasajus commented Mar 9, 2015

It would be nice if there was an explicit and required way in the grpc streams to distinguish them from others (for instance normal web traffic). This way a single port could serve a web page and the services via grpc. Options that come to mind are:

  • Either add a header to all grpc stream (grpc-stream or grpc-version or something like that)
  • Use a special method (like grpc) in the :method header

Cheers 🍻

@louiscryan
Copy link
Contributor

We handle this by mandating a Content-Type of "application/grpc". Is that insufficient

@acasajus
Copy link
Author

Oops. I missed that in
https://github.com/grpc/grpc-common/blob/master/PROTOCOL-HTTP2.md

Cheers,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants