Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In geperated xxxGrpc.java, remove javax.annotation, use jakarta.annotation.Generated #10343

Closed
anborg opened this issue Jul 4, 2023 · 2 comments

Comments

@anborg
Copy link

anborg commented Jul 4, 2023

In generated xxxGrpc.java, remove javax.annotation, use jakarta.annotation.Generated

https://github.com/anborg/corp-model/blob/7e5bc349e542e89a615203f4bc42c05185c6a07b/src/zgen/proto/java/corp/service/CaseServiceGrpc.java#L7C1-L7C29

https://github.com/anborg/corp-model/blob/7e5bc349e542e89a615203f4bc42c05185c6a07b/pom.xml#L142

Generated class

@javax.annotation.Generated(
    value = "by gRPC proto compiler (version 1.56.0)",
    comments = "Source: case-service.proto")
@io.grpc.stub.annotations.GrpcGenerated
public final class CaseServiceGrpc {

  private CaseServiceGrpc() {}

  public static final String SERVICE_NAME = "corp.model.CaseService";

  // Static method descriptors that strictly reflect the proto.
  private static volatile io.grpc.MethodDescriptor<corp.model.Model.ById,
      corp.model.Model.Case> getGetMethod;

  @io.grpc.stub.annotations.RpcMethod(
      fullMethodName = SERVICE_NAME + '/' + "get",
      requestType = corp.model.Model.ById.class,
      responseType = corp.model.Model.Case.class,
@sanjaypujare
Copy link
Contributor

There is already an issue #9179 which talks about jakarta.annotation.Generated not being appropriate. @anborg if you agree this can be closed as duplicate of that.

@ejona86
Copy link
Member

ejona86 commented Aug 1, 2023

Seems like this is resolved. If not, comment, and it can be reopened.

@ejona86 ejona86 closed this as completed Aug 1, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants