Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Hangs when generating Awesome theme after JSON Resume theme #182

Closed
peternowee opened this issue Nov 26, 2016 · 2 comments
Closed
Milestone

Comments

@peternowee
Copy link
Contributor

The automated tests of test-themes.js seem to hang when generating the awesome theme after any of the jsonresume-theme-... themes:

  Testing themes against JANE-Q-FULLSTACKER resume (FRESH)
    ✓ HELLO-WORLD theme (FRESH) should generate without throwing an exception
    ✓ COMPACT theme (FRESH) should generate without throwing an exception (2275ms)
    ✓ MODERN theme (FRESH) should generate without throwing an exception (1645ms)
    ✓ UNDERSCORE theme (FRESH) should generate without throwing an exception
    ✓ AWESOME theme (FRESH) should generate without throwing an exception (4777ms)
    ✓ POSITIVE theme (FRESH) should generate without throwing an exception (1481ms)
    ✓ JSONRESUME-THEME-BOILERPLATE theme (FRESH) should generate without throwing an exception (516ms)
    ✓ JSONRESUME-THEME-SCEPTILE theme (FRESH) should generate without throwing an exception (1119ms)
    ✓ JSONRESUME-THEME-MODERN theme (FRESH) should generate without throwing an exception (394ms)
    ✓ JSONRESUME-THEME-CLASSY theme (FRESH) should generate without throwing an exception (327ms)

  Testing themes against JOHNNY-TROUBLE resume (FRESH)
    ✓ HELLO-WORLD theme (FRESH) should generate without throwing an exception
    ✓ COMPACT theme (FRESH) should generate without throwing an exception (1553ms)
    ✓ MODERN theme (FRESH) should generate without throwing an exception (1313ms)
    ✓ UNDERSCORE theme (FRESH) should generate without throwing an exception
^C

The AWESOME theme should be next, but the thread just goes to 100% CPU until I kill it manually after a few minutes.

For a minimal reproducible example:

  • In test/all.js comment out all test scripts except test-themes.
  • In test/scripts/test-themes.js edit the list of genTheme() calls to only:
    genTheme(fmt, src, 'jsonresume-theme-boilerplate', 'node_modules/jsonresume-theme-boilerplate' );
    genTheme(fmt, src, 'awesome');

This problem occurs with both the current HEAD of branch master (1.8.0) and the current HEAD of branch dev (1.9.0) and in both Node.js 0.10.29 on Debian Jessie and Node.js 4.6.1 on Debian unstable.

@hacksalot
Copy link
Owner

hacksalot commented Jan 29, 2018

EXTREMELY helpful. Thanks for this. I noticed the errors and have pulled the tests from Travis (which also shows the hang) temporarily while we sort it out.

@hacksalot hacksalot added this to the v1.9.0 milestone Jan 29, 2018
@hacksalot
Copy link
Owner

Should be fixed in 1.9.0-beta. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants