Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: handlebars-lang/handlebars.js
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.4.5
Choose a base ref
...
head repository: handlebars-lang/handlebars.js
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.5.0
Choose a head ref
  • 12 commits
  • 25 files changed
  • 7 contributors

Commits on Oct 9, 2019

  1. Configuration menu
    Copy the full SHA
    feb60f8 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2019

  1. fix: prevent zero length tokens in raw-blocks (#1577)

    This comment ensures that the lexer is not stuck on zero-length tokens, in raw-blocks like {{{{a}}}} {{{{/a}}}}
    nknapp authored Oct 20, 2019
    Configuration menu
    Copy the full SHA
    aaab609 View commit details
    Browse the repository at this point in the history
  2. fix: non-eager matching raw-block-contents

    In 4.4.4 the block-contents was matched with an eager match, which means
    that with multiple raw-blocks of the same kind, the block was spanned
    over the first ending-tag until the last one.
    This commit replaces this by a non-eager match.
    
    closes #1579
    nknapp committed Oct 20, 2019
    Configuration menu
    Copy the full SHA
    fd2e5c9 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2019

  1. Merge branch '4.4.x' into 4.x

    nknapp committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    a15d01d View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2019

  1. fix: add guard to if & unless helpers (#1549)

    fixes #1548
    
    - add a guard to show readable syntax error for if / unless helper
    - prevents against 3 different errors that can be generated by different systax errors
    ErisDS authored and nknapp committed Oct 27, 2019
    Configuration menu
    Copy the full SHA
    c76ded8 View commit details
    Browse the repository at this point in the history
  2. Use objects for hash value tracking

    The use of arrays was incorrect for the data type and causing problems when hash keys conflicted with array behaviors.
    
    Fixes #1194
    
    (cherry picked from commit 768ddbd)
    kpdecker authored and nknapp committed Oct 27, 2019
    Configuration menu
    Copy the full SHA
    7fcf9d2 View commit details
    Browse the repository at this point in the history
  3. Add Handlebars.parseWithoutProcessing (#1584)

    When authoring tooling that parses Handlebars files and emits Handlebars
    files, you often want to preserve the **exact** formatting of the input.
    The changes in this commit add a new method to the `Handlebars`
    namespace: `parseWithoutProcessing`. Unlike, `Handlebars.parse` (which
    will mutate the parsed AST to apply whitespace control) this method will
    parse the template and return it directly (**without** processing
    :wink:).
    
    For example, parsing the following template:
    
    ```hbs
     {{#foo}}
       {{~bar~}} {{baz~}}
     {{/foo}}
    ```
    
    Using `Handlebars.parse`, the AST returned would have truncated the
    following whitespace:
    
    * The whitespace prior to the `{{#foo}}`
    * The newline following `{{#foo}}`
    * The leading whitespace before `{{~bar~}}`
    * The whitespace between `{{~bar~}}` and `{{baz~}}`
    * The newline after `{{baz~}}`
    * The whitespace prior to the `{{/foo}}`
    
    When `Handlebars.parse` is used from  `Handlebars.precompile` or
    `Handlebars.compile`, this whitespace stripping is **very** important
    (these behaviors are intentional, and generally lead to better rendered
    output).
    
    When the same template is parsed with
    `Handlebars.parseWithoutProcessing` none of those modifications to the
    AST are made. This enables "codemod tooling" (e.g. `prettier` and
    `ember-template-recast`) to preserve the **exact** initial formatting.
    Prior to these changes, those tools would have to _manually_ reconstruct
    the whitespace that is lost prior to emitting source.
    rwjblue authored and nknapp committed Oct 27, 2019
    Configuration menu
    Copy the full SHA
    62ed3c2 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2019

  1. Add missing types for the Exception class properties (#1583)

    * Convert Exception to a class
    * Add node param type declaration
    * Test the types
    kabirbaidhya authored and nknapp committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    b8913fc View commit details
    Browse the repository at this point in the history
  2. Resolve deprecation warning message from eslint while running eslint (#…

    …1586)
    
    * Resolve eslint deprecation warning
    
      There was a DeprecationWarning message from eslint saying that `ecmaFeatures` property has 
      been deprecated.
      Moved it under the `parserOptions` as per recommended here - 
      https://eslint.org/docs/user-guide/migrating-to-2.0.0.
    * Set escmaVersion = 6
    * Use ES6 built-in global variables
    * Remove flags in favor of ecmaVersion
    kabirbaidhya authored and nknapp committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    7052e88 View commit details
    Browse the repository at this point in the history
  3. chore: add eslint-plugin-compat and eslint-plugin-es5

    - tests are not compiled with babel and must thus be in
      es5
    - we don't use polyfills, so we need to make sure no
      functions aren't used that are not supported by popular browsers. (like Object.assign in Safari and IE11)
    - Boths are errors that usually only appear when running
      tests in SauceLabs, which happens only on _after_
      merging a PR.
    nknapp committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    088e618 View commit details
    Browse the repository at this point in the history
  4. Update release notes

    nknapp committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    a243067 View commit details
    Browse the repository at this point in the history
  5. v4.5.0

    nknapp committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    b24797d View commit details
    Browse the repository at this point in the history
Loading