Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing failing and disabled test following bump in dependency to version 1.5.15 for package org.hl7.fhir.testcases:fhir-test-cases #6200

Open
epeartree opened this issue Aug 7, 2024 · 0 comments

Comments

@epeartree
Copy link
Collaborator

The project parent POM declares dependency to package org.hl7.fhir.testcases:fhir-test-cases which was bumped to version 1.5.15. As a result, the test defined in class FhirPatchCoreTest is failing for two reasons:

1- the test tries to parse file /org/hl7/fhir/testcases/r5/patch/fhir-path-tests.xml provided by the dependency but fails since xml closing tags are missing on line 231 and 245. this issue should be fixed by core PR-184;

2- the test also fails due to the introduction of new XML tags in both parsed files (see FhirPatchCoreTest#parameters). the test expects a format of:

<case>
    <input></input>
    <diff></diff>
    <output></output>
</case>

where version 1.5.15 introduces tag <error> that can replace tag <output>. the new tag can be found:

  • line 1413 for file /org/hl7/fhir/testcases/r4/patch/fhir-path-tests.xml
  • line 1528 for file /org/hl7/fhir/testcases/r5/patch/fhir-path-tests.xml

What needs to be done:
To determine a proper way to handle the new tag to get the FhirPatchCoreTest passing again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant