Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to use a request decoration instead of request.auth.session #101

Closed
hueniverse opened this issue Jan 2, 2016 · 1 comment · Fixed by #103
Closed

Switch to use a request decoration instead of request.auth.session #101

hueniverse opened this issue Jan 2, 2016 · 1 comment · Fixed by #103
Labels
breaking changes Change that can breaking existing code dependency Update module dependency
Milestone
5.0

Comments

@hueniverse
Copy link
Contributor

See: hapijs/yar#88

I am removing the request.session and request.auth.session placeholders from hapi. Should not break anything but you should consider a breaking change to move the methods set by this plugin elsewhere directly on the request.
@hueniverse hueniverse added breaking changes Change that can breaking existing code dependency Update module dependency labels Jan 2, 2016
@jaw187 jaw187 self-assigned this Jan 4, 2016
@jaw187 jaw187 added this to the 5.0 milestone Jan 5, 2016
@jaw187 jaw187 mentioned this issue Jan 5, 2016
Merged
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot unassigned jaw187 Jan 9, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
breaking changes Change that can breaking existing code dependency Update module dependency
Projects
None yet
Milestone
5.0
Development

Successfully merging a pull request may close this issue.

move away from request.auth.session jaw187/hapi-auth-cookie
2 participants
@hueniverse @jaw187