Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share buttons for boards #300

Open
belihub opened this issue Mar 16, 2016 · 6 comments
Open

Share buttons for boards #300

belihub opened this issue Mar 16, 2016 · 6 comments

Comments

@belihub
Copy link

belihub commented Mar 16, 2016

Could have individual share buttons on hover over yellow post-its on hasjob.co, so people browsing can quickly share it with their friends (pm's and email included if possible)

@jace
Copy link
Member

jace commented Mar 17, 2016

The job pages have share buttons. We need them for sub-boards.

@jace jace changed the title Share buttons Share buttons for boards Mar 20, 2016
@jace
Copy link
Member

jace commented Mar 20, 2016

The board's share buttons will also obsolete the tiny twitter link in the footer, which is a terrible place to put share buttons.

@iambibhas
Copy link
Contributor

What are sub-boards?

@jace
Copy link
Member

jace commented Apr 25, 2016

@jace
Copy link
Member

jace commented Apr 25, 2016

When you visit https://hasjob.co/, you're actually visiting a sub-board named www. If there is no such board, you'll see all jobs and hardcoded values in the templates. If the www board exists, data from that is used instead. Doing this lets us specify consistent behaviour in the templates between main board and sub-boards.

When you visit a job page, if that job is not hosted on the current sub-board, you'll get redirected to the sub-board it is on, defaulting to www board. This check is not performed when you're on the www board. You'll see this around the code in the form of g.board.is_root and g.board.not_root checks.

All pages in sub-boards also have a <link rel="canonical" href="…"/> that points to the same page on the root board, so Google doesn't penalise us for duplicating pages.

@iambibhas
Copy link
Contributor

For the sub-board, can do something like this? -

selection_650

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants