inject_filter_options is added to template context even when not needed

[jace]

In hasjob.views.helper.inject_filter_options, as an app context processor, it's called for every single query whether it's needed or not. Rather than insert actual values, it should insert functions which the template can call when needed.

[iambibhas]

The issue with inserting functions is that cache can't be set. It can't pickle function objects.

[jace]

Fair point, so let's have the outer function return an inner function, which hits cache. Rather than return a dict of job_location_filters, job_type_filters and job_category_filters, we return a dict with a single key, job_filters, which is a function that when called returns another dict with the above three keys.

The templates will have to be updated accordingly.

[iambibhas]

But the values of job_filters will still be a function, right? Which will raise the same issue?

[jace]

No, it will be actual values.