Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose option for configuring user-debug or eng builds #24

Open
richnetdesign opened this issue Jul 19, 2020 · 2 comments
Open

Expose option for configuring user-debug or eng builds #24

richnetdesign opened this issue Jul 19, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@richnetdesign
Copy link

For developers or recovery purposes, would be helpful to allow configuring options in aosp-build to make eng or user-debug builds.

This is how it can be done manually
TARGET_BUILD_TYPE=debug breakfast sargo eng
TARGET_BUILD_TYPE=debug brunch sargo eng

Discussed here
https://source.android.com/setup/build/building

@ypid ypid added the enhancement New feature or request label Jul 19, 2020
@ypid
Copy link
Collaborator

ypid commented Jul 19, 2020

would be helpful to allow configuring options in aosp-build to make eng or user-debug builds

Yes, that would be helpful. I guess for any serious person building and maintaining a custom ROM, a second phone running user-debug or so is basic. I currently only partly have a second phone that is the same as my main one laying around, but I definitional plan to get one again for the Android 11 update.

So, feel free to implement this.

@ypid
Copy link
Collaborator

ypid commented Feb 6, 2021

Currently, this can only be configured using:

variant: user

I am not sure what the best way to expose this is.

Pro config.yml:

  • variant will change the build output so it should be contained in the config.

Pro for make parameter:

  • Simpler to make a user debug build.

For the time being, I would propose to leave it as it is unless more compelling arguments for exposing it as make parameter are found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants