Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to cover the updated type signatures for HederaToken and createToken functions #509

Closed
lukelee-sl opened this issue Sep 10, 2022 · 0 comments · Fixed by #510
Closed
Assignees
Labels
enhancement New feature or request P1 process Build, test and deployment-process related tasks
Milestone

Comments

@lukelee-sl
Copy link
Member

Problem

The types of several fields were updated to better align with protobuf and documentation as outlined in these two tasks.
hashgraph/hedera-smart-contracts#56
hashgraph/hedera-services#3902

We need to ensure that the acceptance test exercise both the new types and the old as the old types signatures are still supported in hedera services.

Solution

Ensure that acceptance tests run correctly with the new type signatures.
Write a new acceptance test that exercise the create token functions with the old type signatures.

Alternatives

No response

@lukelee-sl lukelee-sl added the enhancement New feature or request label Sep 10, 2022
@lukelee-sl lukelee-sl self-assigned this Sep 10, 2022
@Nana-EC Nana-EC added this to the 0.8.0 milestone Sep 12, 2022
@Nana-EC Nana-EC added P1 process Build, test and deployment-process related tasks labels Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P1 process Build, test and deployment-process related tasks
Projects
Archived in project
2 participants