Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support older contract state in eth_getStorageAt #790

Closed
georgi-l95 opened this issue Dec 22, 2022 · 1 comment · Fixed by #1016
Closed

Support older contract state in eth_getStorageAt #790

georgi-l95 opened this issue Dec 22, 2022 · 1 comment · Fixed by #1016
Assignees
Labels
enhancement New feature or request limechain P1
Milestone

Comments

@georgi-l95
Copy link
Collaborator

georgi-l95 commented Dec 22, 2022

With the refactoring performed in this PR we now support:

  • Current state of a contract
  • Previous state of a contract a contract, if we know the exact block number this state change has been made.

We are missing support of:

  • Previous state of a contract, without specifying the exact block number this change occurred. For example we pass a block number and return the state of the contract prior this block number.

This might require some changes to the mirror-node endpoint, for example support of timestamp.
Only way to do it directly in the relay is to search every block before the one we pass as parameter in search for this change. This is highly unoptimised and not a solution.

@georgi-l95
Copy link
Collaborator Author

Waiting for hashgraph/hedera-mirror-node#5517 to be merged.

@georgi-l95 georgi-l95 self-assigned this Mar 1, 2023
@georgi-l95 georgi-l95 added this to the 0.21.0 milestone Mar 23, 2023
@georgi-l95 georgi-l95 linked a pull request Mar 25, 2023 that will close this issue
2 tasks
@Nana-EC Nana-EC added enhancement New feature or request limechain P1 labels Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request limechain P1
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants