You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Problem
We currently use nodeAccountId as the node label across the signature verification process.
This works now, however, since a node account id can change it's best to use the nodeId which will remain the same.
Solution
Update Node signature verifier process to use NodeId value instead NodeAccountId
Add a getNodeIdString() in AddressBookEntry to be used in place of getNodeAccountIdString()
Replace nodeAccountIDPubKeyMap with nodeIdPubKeyMap which calls getNodeIdString()
Update NodeSignatureVerifier to call nodeIdPubKeyMap
Update comment references to be clear nodeId is used over nodeAccountId
Currently we have metrics that pull shard, realm and num from the nodeAccountId, to appropriately replace nodeAccountId with nodeId, we need to consider how valuable these metrics dimension are and how we might preserve them.
Alternatives
Leave as
Additional Context
A node entry nodeId remains the same but the nodeAccountId may change
The text was updated successfully, but these errors were encountered:
Problem
We currently use nodeAccountId as the node label across the signature verification process.
This works now, however, since a node account id can change it's best to use the nodeId which will remain the same.
Solution
Update Node signature verifier process to use NodeId value instead NodeAccountId
getNodeIdString()
inAddressBookEntry
to be used in place ofgetNodeAccountIdString()
nodeAccountIDPubKeyMap
withnodeIdPubKeyMap
which callsgetNodeIdString()
nodeIdPubKeyMap
Currently we have metrics that pull shard, realm and num from the nodeAccountId, to appropriately replace nodeAccountId with nodeId, we need to consider how valuable these metrics dimension are and how we might preserve them.
Alternatives
Leave as
Additional Context
A node entry
nodeId
remains the same but thenodeAccountId
may changeThe text was updated successfully, but these errors were encountered: