Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NodeId instead of NodeAccountId in Node Signature Verification Flow #1976

Closed
Nana-EC opened this issue May 12, 2021 · 2 comments · Fixed by #4553
Closed

Use NodeId instead of NodeAccountId in Node Signature Verification Flow #1976

Nana-EC opened this issue May 12, 2021 · 2 comments · Fixed by #4553
Labels
enhancement Type: New feature java Pull requests that update Java code P2 parser Area: File parsing
Milestone

Comments

@Nana-EC
Copy link
Contributor

Nana-EC commented May 12, 2021

Problem
We currently use nodeAccountId as the node label across the signature verification process.
This works now, however, since a node account id can change it's best to use the nodeId which will remain the same.

Solution
Update Node signature verifier process to use NodeId value instead NodeAccountId

  • Add a getNodeIdString() in AddressBookEntry to be used in place of getNodeAccountIdString()
  • Replace nodeAccountIDPubKeyMap with nodeIdPubKeyMap which calls getNodeIdString()
  • Update NodeSignatureVerifier to call nodeIdPubKeyMap
  • Update comment references to be clear nodeId is used over nodeAccountId

Currently we have metrics that pull shard, realm and num from the nodeAccountId, to appropriately replace nodeAccountId with nodeId, we need to consider how valuable these metrics dimension are and how we might preserve them.

Alternatives
Leave as

Additional Context
A node entry nodeId remains the same but the nodeAccountId may change

@Nana-EC Nana-EC added enhancement Type: New feature P2 parser Area: File parsing java Pull requests that update Java code labels May 12, 2021
@steven-sheehy
Copy link
Member

I think if we switch to nodeId we can just drop realm and shard until the time comes that they actually have a non-zero value.

@steven-sheehy steven-sheehy added this to the 0.66.0 milestone Sep 30, 2022
@steven-sheehy steven-sheehy linked a pull request Sep 30, 2022 that will close this issue
2 tasks
@steven-sheehy
Copy link
Member

Fixed by #4553

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature java Pull requests that update Java code P2 parser Area: File parsing
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants