Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST API metrics by client IP #2130

Closed
steven-sheehy opened this issue Jun 17, 2021 · 0 comments · Fixed by #2174
Closed

REST API metrics by client IP #2130

steven-sheehy opened this issue Jun 17, 2021 · 0 comments · Fixed by #2174
Assignees
Labels
enhancement Type: New feature P2 rest Area: REST API
Milestone

Comments

@steven-sheehy
Copy link
Member

Problem
For deployments that we whitelist client IPs, it would be helpful to have REST API metrics broken down by those client IPs so we get more insight into how the clients are using the product.

Solution
Add client's IP to the metric. It might already be there as I see a real_ip listed in some sample elastic output in swagger-stats repo.

Alternatives
Use metrics via a proxy.

Additional Context

@steven-sheehy steven-sheehy added enhancement Type: New feature P2 rest Area: REST API labels Jun 17, 2021
@ijungmann ijungmann self-assigned this Jun 21, 2021
@ijungmann ijungmann mentioned this issue Jun 24, 2021
2 tasks
@steven-sheehy steven-sheehy added this to the Mirror 0.37.0 milestone Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature P2 rest Area: REST API
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants