Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure to process Int64Value in a model #170

Closed
anthony-swirldslabs opened this issue Jan 16, 2024 · 3 comments
Closed

Failure to process Int64Value in a model #170

anthony-swirldslabs opened this issue Jan 16, 2024 · 3 comments
Labels
Bug An error that causes the feature to behave differently than what was expected based on design.

Comments

@anthony-swirldslabs
Copy link
Contributor

Description

hashgraph/hedera-protobufs#312 added an Int64Value field to services/contract_call_local.proto recently.

Ever since, PBJ integration tests fail to build: https://github.com/hashgraph/pbj/actions/runs/7545723496/job/20541986405

with a message:

> Task :generatePbjSource FAILED
Exception while processing file: /runner/_work/pbj/pbj/pbj-integration-tests/build/repos/hapi/services/contract_call_local.proto

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':generatePbjSource'.
> Failed to find fully qualified message type for [Int64Value] in file [/runner/_work/pbj/pbj/pbj-integration-tests/build/repos/hapi/services/contract_call_local.proto] imports = [/runner/_work/pbj/pbj/pbj-integration-tests/build/repos/hapi/services/contract_types.proto, /runner/_work/pbj/pbj/pbj-integration-tests/build/repos/hapi/services/basic_types.proto, /runner/_work/pbj/pbj/pbj-integration-tests/build/repos/hapi/services/response_header.proto, /runner/_work/pbj/pbj/pbj-integration-tests/build/repos/hapi/services/query_header.proto]

Steps to reproduce

See the failing build above. Build in pbj-integration-tests should fail this way.

Additional context

No response

Hedera network

other

Version

v

Operating system

None

@anthony-swirldslabs anthony-swirldslabs added the Bug An error that causes the feature to behave differently than what was expected based on design. label Jan 16, 2024
@anthony-swirldslabs
Copy link
Contributor Author

The type reference Int64Value should be prefixed with google.protobuf., similar to:

https://github.com/hashgraph/hedera-protobufs/blob/8342c9193e5efb7e035972e7ce4ce6bd2d4b4211/services/contract_call_local.proto#L133

I have a fix for this. Now I just need to get permissions to push to that repo to publish a PR.

@imalygin
Copy link
Member

Here is the fix pending:

hashgraph/hedera-protobufs#316

@anthony-swirldslabs
Copy link
Contributor Author

This issue can now be resolved because 1) it's being fixed under a different issue (see link above); and 2) it's not really a bug in PBJ.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug An error that causes the feature to behave differently than what was expected based on design.
Projects
None yet
Development

No branches or pull requests

2 participants