Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: hashicorp/go-metrics
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.3.5
Choose a base ref
...
head repository: hashicorp/go-metrics
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.3.6
Choose a head ref
  • 2 commits
  • 2 files changed
  • 2 contributors

Commits on Dec 29, 2020

  1. Use the same Help for metrics with and without labels

    When metrics are pre-registered with Help and without labels,
    when issuing metrics with labels, the help was filled with
    the key_name.
    
    But prometheus client enforces help to be consistent accross
    several elements, so, it can break at Runtime if a metric
    has been declared without its labels and later issued this metric
    with labels.
    
    In order to fix this, we store the help declared at startup for
    each key, so, when declaring a metric with some labels, we try
    to re-used pre-declared help for the metric.
    
    It should fix the issue that appeared with Consul 1.9.x and
    fix hashicorp/consul#9471
    pierresouchay committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    923ff58 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2021

  1. Merge pull request #122 from pierresouchay/metrics_with_label_use_pre…

    …_registered_help
    
    Use the same Help for metrics with and without labels
    banks committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    8ca742b View commit details
    Browse the repository at this point in the history
Loading