Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy binary under the bin directory #5082

Merged
merged 1 commit into from
Oct 13, 2017
Merged

Copy binary under the bin directory #5082

merged 1 commit into from
Oct 13, 2017

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Jun 29, 2017

build: copy binary under the bin directory

This patch fixes Makefile to create bin directory and copy created binary under the directory.

Copy link
Contributor

@SwampDragons SwampDragons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks again :)

@ChrisLundquist
Copy link
Collaborator

This threw me off today. after make I tried ls -la bin and expected bin/packer, but saw bin was actually what I wanted.

@mwhooker
Copy link
Contributor

ahh, I see, this behavior changed in #4860 and must have inadvertently broken this. thanks!

@mwhooker mwhooker merged commit 7349e4f into hashicorp:master Oct 13, 2017
@mwhooker mwhooker added the core Core components of Packer label Oct 13, 2017
@ghost
Copy link

ghost commented Apr 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core Core components of Packer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants