Use regex based approach to detect attached disks

[DanHam]

This PR updates the code in step_clone to use a regexp based approach to detect attached disks. Overall, I believe this is a better approach as:

• It doesn't use any hard coded values and so future proofs the code slightly.
• It reduces complexity and makes the code easier/more obvious to read.

It follows the approach used here in step_clean...

Of course, these reasons can also be read as reasons why my previous code sucked slightly... so please consider this an attempt at making amends! 😄

[SwampDragons]

I think I'd like to see a comment explaining what the regex is looking for and why; generally I find that regexes are hard to understand at a glance and I'd like some note in here for maintainability.

[DanHam]

@SwampDragons

I'd like to see a comment explaining what the regex is looking for and why; generally I find that regexes are hard to understand at a glance and I'd like some note in here for maintainability

Ditto on regexp's! I've now added a (somewhat lengthy) comment to try and explain why a regex is being used here. Is this the type of thing you were after? Or perhaps you feel this is a little too much?

Just let me know if you want me to have another go at that...

[SwampDragons]

I was all ready to tease you for making a fifteen-line comment but then I read it and... I like it. Thanks for this.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.