Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show error message when -on-error=[ask|abort] #6253

Merged
merged 3 commits into from
May 8, 2018
Merged

show error message when -on-error=[ask|abort] #6253

merged 3 commits into from
May 8, 2018

Commits on May 8, 2018

  1. Remove redundant error message.

    @mwhooker
    mwhooker committed May 8, 2018
    Configuration menu
    Copy the full SHA
    44012b2 View commit details
    Browse the repository at this point in the history

  2. Display build error when on-error=ask|abort

    @mwhooker
    mwhooker committed May 8, 2018
    Configuration menu
    Copy the full SHA
    0a18421 View commit details
    Browse the repository at this point in the history

  3. Use fmt to convert whatever's in error to a string. 

    This way we don't crash if someone sticks something else in the error
key in the state bag (which a quick glance at the code tells me we're
already doing.

Perhaps in the future we can add an error attribute to the state bag
but for now this will have to suffice.
    @mwhooker
    mwhooker committed May 8, 2018
    Configuration menu
    Copy the full SHA
    5e6e12c View commit details
    Browse the repository at this point in the history