Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_iam_policy_document doesn't detect invalid SIDs #10771

Closed
ghost opened this issue Nov 6, 2019 · 3 comments · May be fixed by #12262
Closed

aws_iam_policy_document doesn't detect invalid SIDs #10771

ghost opened this issue Nov 6, 2019 · 3 comments · May be fixed by #12262
Labels
service/iam Issues and PRs that pertain to the iam service.

Comments

@ghost
Copy link

ghost commented Nov 6, 2019 •
edited by ghost
Loading

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version

v0.12.12

Affected Resource(s)

  • aws_iam_policy_document

Terraform Configuration Files

Sample block:

data "aws_iam_policy_document" "test_doc" {
  statement {
    sid = "invalid-sid"
    actions = ["*"]
    resources = ["*"]
    effect = "Allow"
  }
}

Expected Behavior

Terraform will fail to run the configuration because the sid field does not match the expression [a-zA-Z0-9]+.

Actual Behavior

Terraform begins to run the configuration with the policy JSON where it is used and AWS reports that the SID is invalid.
@ghost ghost added the service/iam Issues and PRs that pertain to the iam service. label Nov 6, 2019
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 6, 2019
@kangaechu kangaechu mentioned this issue Mar 5, 2020
Open
@justinretzolk
Copy link
Member

Hey @clar-cmp 👋 Thank you for taking the time to file this issue! Given that there's been a number of AWS provider releases since you initially filed it, can you confirm whether you're still experiencing this behavior?

@justinretzolk justinretzolk added waiting-response Maintainers are waiting on response from community or contributor. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 9, 2021
@ghost
Copy link
Author

ghost commented Dec 15, 2021

Hi Justin, I haven't checked this in a long time and don't have the time to confirm. You can close this if you think it's not an issue any more, or if no one else can verify it.

@github-actions github-actions bot removed the waiting-response Maintainers are waiting on response from community or contributor. label Dec 15, 2021
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
service/iam Issues and PRs that pertain to the iam service.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add validation for aws_iam_policy_document sid
1 participant
@justinretzolk