Add ability to add features to existing feature groups in Sagemaker

[aShevc]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Currently when one adds new feature to the existing Sagemaker feature group, it forces the destruction of resource. However, since FeatureAdditions functionality has been introduced to the UpdateFeatureGroup API call, this must not be the case.

New or Affected Resource(s)

• aws_sagemaker_feature_group

Potential Terraform Example

resource "aws_sagemaker_feature_group" "feature_group" {
  feature_group_name                   = "some name"
// ...rest of the configuration and features

// the feature definition below is the new feature in he feature group
    feature_definition {
      feature_name = "example_add"
      feature_type  = string
    }
}

Expected Behavior

When adding a feature to feature group, the feature group should be updated with the new feature.

Actual Behavior

Executing Terraform plan gives the following:

  # aws_sagemaker_feature_group.feature_group[0] must be replaced
-/+ resource "aws_sagemaker_feature_group" "feature_group" {

      + feature_definition { # forces replacement
          + feature_name = "example_add"
          + feature_type = "String"
        }
...

    }

Plan: 1 to add, 0 to change, 1 to destroy.

References

• resourceFeatureGroupUpdate - it looks like this is the function needs to be updated

[DrFaust92]

looking into this

[xianwill]

@DrFaust92 just wanted to see if you were able to make any progress on this?

[DrFaust92]

@xianwill im looking into this but unfortunately this proved to not as trivial as removal of features requires recreate and i wasnt able to make this work properly in my tests. if anyone wants to take a crack at this i can unassign myself as this is not a top priority ticket for me.

[aShevc]

@DrFaust92 I have started looking at the issue, however, similarly, struggle to make Terraform force changes in case if the list of feature definitions change simultaneously with giving the ability to add new features. Can you share some of your work so I could have a sneak peek on potential solutions?

[nealrp]

Any update on this? Full recreation limits use of this resource since all data stored in the feature also gets deleted.

[lsamaha1-chwy]

Any updates on getting a release with this support?