Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: compressionType is not a valid parameter in extra connection attributes #27852

Closed
shanmugahp opened this issue Nov 17, 2022 · 8 comments · Fixed by #28130
Closed

[Bug]: compressionType is not a valid parameter in extra connection attributes #27852

shanmugahp opened this issue Nov 17, 2022 · 8 comments · Fixed by #28130
Labels
bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/dms Issues and PRs that pertain to the dms service.
Milestone

Comments

@shanmugahp
Copy link

shanmugahp commented Nov 17, 2022

Terraform Core Version

1.0.5

AWS Provider Version

4.8.0

Affected Resource(s)

aws_dms_endpoint

Expected Behavior

Terraform should not send the default value for compressionType and Resource is created

Actual Behavior

Endpoint fails to create as aws has removed the compressionType attribute for dms s3 as source endpoint . Terraform is sending default value of compressionType=None causing the call to fail.

      + cdc_path                         = "changedata"
      + compression_type                 = "NONE"
      + csv_delimiter                    = "|"
      + csv_row_delimiter                = "\\n"
      + data_format                      = "csv"
      + data_page_size                   = 1048576
      + date_partition_delimiter         = "slash"
      + date_partition_enabled           = false
      + date_partition_sequence          = "yyyymmdd"

Relevant Error/Panic Output Snippet

Error: Error creating DMS endpoint: InvalidParameterValueException: Unsupported value 'compressionType' for extra connection attributes
	status code: 400, request id: 89916c08-3fa2-454e-affb-2c69c6572df1

  with module.data-lake.module.sources.module.source_activities[0].aws_dms_endpoint.main[0],
  on ../../main/data-sources/s3-data-source/main.tf line 5, in resource "aws_dms_endpoint" "main":
   5: resource "aws_dms_endpoint" "main" {

Terraform Configuration Files

resource "aws_dms_endpoint" "main" {

endpoint_id = var.resource_prefix
endpoint_type = "source"
ssl_mode = "none"
tags = var.application_tags
engine_name = "s3"

s3_settings {
bucket_name = var.source_bucket_id
bucket_folder = var.source_bucket_folder
service_access_role_arn = var.activities_dms_s3_role_arn
external_table_definition = var.external_table_mappings
csv_delimiter = var.csv_delimiter
cdc_path = var.cdc_path
csv_null_value = var.csv_null_value
csv_row_delimiter = var.csv_row_delimiter
}

Steps to Reproduce

Create a DMS source endpoint with S3 as source

Debug Output

No response

Panic Output

No response

Important Factoids

No response

References

Would you like to implement a fix?

No response

@shanmugahp shanmugahp added bug Addresses a defect in current functionality. needs-triage Waiting for first response or review from a maintainer. labels Nov 17, 2022
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/dms Issues and PRs that pertain to the dms service. label Nov 17, 2022
@JoeHutchins0n
Copy link

JoeHutchins0n commented Nov 18, 2022

Same problem here. The Terraform resource for the DMS S3 endpoint I was testing broke overnight. Very frustrating.

I compiled a local copy of the provider and found at least 3 other attributes that have had their support removed as well as CompressionType:

  • DatePartitionDelimiter
  • DatePartitionEnabled
  • DatePartitionSequence

There could be more to.

@rossbush
Copy link

Our pipelines are silent. Please make this a high priority.

@jeffarredondo
Copy link
Contributor

jeffarredondo commented Nov 18, 2022

Ok at least I'm not crazy. Ran into something similar for MySQL as well when testing a potential change to include the sybase engine

@thebrettd
Copy link

I believe I am being impacted by this also.

I believe there may be a related issue with an old fix: #14620

@breathingdust breathingdust added regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 29, 2022
@YakDriver
Copy link
Member

AWS has been warning for some time in the console that extra connection attributes would be deprecated (see #23506). Unfortunately, work on new endpoint resources has stalled (#23507). Thank you for bringing these challenges to our attention as we prioritize work.

@github-actions
Copy link

github-actions bot commented Dec 2, 2022

This functionality has been released in v4.45.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jan 2, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/dms Issues and PRs that pertain to the dms service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants