Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: Add experiment_option argument to aws_fis_experiment_template #36413

Open
waditya-jpmc opened this issue Mar 15, 2024 · 2 comments · May be fixed by #36900
Open

[Enhancement]: Add experiment_option argument to aws_fis_experiment_template #36413

waditya-jpmc opened this issue Mar 15, 2024 · 2 comments · May be fixed by #36900
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/fis Issues and PRs that pertain to the fis service.

Comments

@waditya-jpmc
Copy link

waditya-jpmc commented Mar 15, 2024 •
edited by justinretzolk
Loading

Terraform Core Version

1.0

AWS Provider Version

5.0

Affected Resource(s)

aws_fis_experiment_template

Expected Behavior

Terraform Plan getting validated

Actual Behavior

When I use the experiment_option option while creating FIS experiment (as below),

 experiment-options {
    emptyTargetResolutionMode = "skip"
  }

I get below error -

Blocks of type "experiment_options" are not expected here.

I get similar error when using experiment_option instead of experiment_options. This seems to be a bug.

Relevant Error/Panic Output Snippet

Blocks of type "experiment_options" are not expected here.

Terraform Configuration Files

Provider

terraform {
  required_version = ">=1.0"

  required_providers {
    aws = {
      source  = "hashicorp/aws"
      version = ">= 5.0"
    }
  }
}

Steps to Reproduce

Use below template -

resource "aws_fis_experiment_template" "example" {
  description = "example"
  role_arn    = aws_iam_role.example.arn

  stop_condition {
    source = "none"
  }
experiment_options {
    emptyTargetResolutionMode = "skip"
  }

  action {
    name      = "example-action"
    action_id = "aws:ec2:terminate-instances"

    target {
      key   = "Instances"
      value = "example-target"
    }
  }

  target {
    name           = "example-target"
    resource_type  = "aws:ec2:instance"
    selection_mode = "COUNT(1)"

    resource_tag {
      key   = "env"
      value = "example"
    }
  }
}

Debug Output

No response

Panic Output

No response

Important Factoids

AWS docs - https://docs.aws.amazon.com/cli/latest/reference/fis/create-experiment-template.html
Terraform docs - https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/fis_experiment_template

References

AWS docs - https://docs.aws.amazon.com/cli/latest/reference/fis/create-experiment-template.html
Terraform docs - https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/fis_experiment_template

Would you like to implement a fix?

None
@waditya-jpmc waditya-jpmc added the bug Addresses a defect in current functionality. label Mar 15, 2024
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/fis Issues and PRs that pertain to the fis service. label Mar 15, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 15, 2024
@justinretzolk
Copy link
Member

Hey @waditya-jpmc 👋 Thank you for taking the time to raise this! We consider expanded functionality of existing resources to be an enhancement rather than a bug, so I'm going to update the issue to match that. No further action is needed from you at this time; I just like to give a heads up before adjusting issue titles.

@justinretzolk justinretzolk changed the title [Bug]: While creating AWS FIS experiment template, unable to use the argument "experiment-option" [Enhancement]: Add experiment_option argument to aws_fis_experiment_template Mar 20, 2024
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed bug Addresses a defect in current functionality. needs-triage Waiting for first response or review from a maintainer. labels Mar 20, 2024
@nikhil-goenka nikhil-goenka linked a pull request Apr 13, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/fis Issues and PRs that pertain to the fis service.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

f-aws_fis_experiment_template support for experiment options nikhil-goenka/terraform-provider-aws
2 participants
@justinretzolk @waditya-jpmc