Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: Data Sources for Cognito User Pool #36087

Closed
hanoj-budime opened this issue Mar 5, 2024 · 5 comments · Fixed by #37399
Closed

[Enhancement]: Data Sources for Cognito User Pool #36087

hanoj-budime opened this issue Mar 5, 2024 · 5 comments · Fixed by #37399
Labels
good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. new-data-source Introduces a new data source. service/cognitoidp Issues and PRs that pertain to the cognitoidp service.
Milestone
v5.57.0

Comments

@hanoj-budime
Copy link

Description

Currently, we lack real-time descriptions of user pool information, which is crucial for end applications and Terraform operations to gather data. This information includes whether the user pool configuration has MFA activated, password patterns, sign-up enablement, required fields, etc.

Similarly, we are also missing real-time descriptions of app client information. This could prove beneficial for end applications, providing insights into whether the app client auth session timeout settings, etc.

Affected Resource(s) and/or Data Source(s)

data "aws_cognito_user_pool" "describe_user_pool"
{
  "UserPool": {
      "MfaConfiguration": "OFF",
      "Name": "MyUserPool",
      "AutoVerifiedAttributes": [
          "email"
      ],
      "Policies": {
          "PasswordPolicy": {
              "RequireLowercase": true,
              "RequireSymbols": true,
              "RequireNumbers": true,
              "MinimumLength": 8,
              "RequireUppercase": true
          }
      },
      "UsernameAttributes": [
          "email"
      ],
      "Id": "us-west-2_aaaaaaaaa",
  }
}

Potential Terraform Configuration

No response

References

No response

Would you like to implement a fix?

No
@hanoj-budime hanoj-budime added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 5, 2024
@github-actions github-actions bot added the service/cognitoidp Issues and PRs that pertain to the cognitoidp service. label Mar 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 5, 2024
@danquack
Copy link
Contributor

danquack commented Mar 5, 2024 •
edited
Loading

@HanojHanu you mentioned a data source for a specific user pool, but your title also stated a data source for an app client. There is a data source for user_pool_client is that what you are referring to?

From the description, it just appears you want to lookup the properties for a user pool, so just want to make sure I understand what insight you are looking for.

@justinretzolk justinretzolk added the waiting-response Maintainers are waiting on response from community or contributor. label Mar 7, 2024
@hanoj-budime hanoj-budime changed the title [Enhancement]: Data Sources for Cognito User Pool and App Client [Enhancement]: Data Sources for Cognito User Pool Mar 18, 2024
@hanoj-budime
Copy link
Author

Yes, @danquack.

Looking for data source for a specific user pool

@github-actions github-actions bot removed the waiting-response Maintainers are waiting on response from community or contributor. label Mar 18, 2024
@justinretzolk justinretzolk added new-data-source Introduces a new data source. and removed enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Mar 18, 2024
@drewmullen drewmullen added the good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. label Apr 1, 2024
@SolomonHD
Copy link

Yes, we need a data "aws_cognito_user_pool", without we can't get the custom domain attribute. I have to use a pre-existing user pool.

I've got a hack with the import block and the resource "aws_cognito_user_pool" with an ignore_changes lifecycle attached, but it requires that I remove it from state before deleting to avoid errors.

@danquack danquack mentioned this issue May 9, 2024
Merged
@github-actions github-actions bot added this to the v5.57.0 milestone Jun 28, 2024
@github-actions GitHub Actions
Copy link

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. new-data-source Introduces a new data source. service/cognitoidp Issues and PRs that pertain to the cognitoidp service.
Projects
None yet
Milestone
v5.57.0
Development

Successfully merging a pull request may close this issue.

d/cognito_user_pool danquack/terraform-provider-aws
5 participants
@drewmullen @SolomonHD @danquack @justinretzolk @hanoj-budime