Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: r/aws_redshift_cluster_snapshot: Set arn attribute from API response #36915

Open
2 tasks
jar-b opened this issue Apr 15, 2024 · 4 comments · May be fixed by #37996
Open
2 tasks

[Enhancement]: r/aws_redshift_cluster_snapshot: Set arn attribute from API response #36915

jar-b opened this issue Apr 15, 2024 · 4 comments · May be fixed by #37996
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/redshift Issues and PRs that pertain to the redshift service.

Comments

@jar-b
Copy link
Member

jar-b commented Apr 15, 2024 •
edited

Description

The DescribeClusterSnapshots API now returns a SnapshotARN field. The corresponding arn attribute can now be written from this response value.

  • Remove custom ARN construction logic for the arn attribute in favor of the value from the API response
  • Check for value in _basic acceptance test

Affected Resource(s) and/or Data Source(s)

  • aws_redshift_cluster_snapshot

References

Would you like to implement a fix?

None
@jar-b jar-b added enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/redshift Issues and PRs that pertain to the redshift service. labels Apr 15, 2024
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@mgurrie
Copy link

mgurrie commented Apr 16, 2024 •
edited

I am unable to work on this issue due to lack of understanding and time thank you

@madhavvishnubhatta
Copy link
Contributor

@jar-b I am not sure I understand the ask. I see that the arn field is already present in the resource definition, though it is being constructed at the moment (rather than using the output from DescribeClusterSnapshots). Is your suggestion that we use the output rather than constructing it? And if so, why a new field, can we not just modify the existing field?

@jar-b
Copy link
Member Author

jar-b commented Apr 24, 2024

@madhavvishnubhatta - Thanks for your feedback! For some context, I opened this issue based on this item from the AWS SDK release notes:

  • service/redshift: Updates service API and documentation
    • Adds support for Amazon Redshift DescribeClusterSnapshots API to include Snapshot ARN response field.

That said, I overlooked that a synthetic arn attribute was already present in the schema. Your first suggestion is the correct one - now that this computed attribute is available in the API response we can remove the custom ARN construction logic in favor of the SnapshotArn response value. I'll update the issue body accordingly.

@jar-b jar-b changed the title [Enhancement]: r/aws_redshift_cluster_snapshot: Add snapshot_arn attribute [Enhancement]: r/aws_redshift_cluster_snapshot: Set arn attribute from API response Apr 24, 2024
@mgurrie mgurrie mentioned this issue Apr 25, 2024
Open
@nikhil-goenka nikhil-goenka linked a pull request Jun 15, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/redshift Issues and PRs that pertain to the redshift service.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

F/aws redshift cluster snapshot nikhil-goenka/terraform-provider-aws
3 participants
@madhavvishnubhatta @jar-b @mgurrie