Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_redshiftserverless_snapshot_copy_configuration: implement new resource #36809

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marcinbelczewski
Copy link

@marcinbelczewski marcinbelczewski commented Apr 9, 2024

Description

This PR implements aws_redshiftserverless_snapshot_copy_configuration to configure copying of Amazon Redshift Serverless snapshots and recovery points to another region.

This PR does not implement importing resource. This is because Redshift Serverless API misses get-snapshot-copy-configuration action preventing direct get via snapshot copy configuration ID and rather listing all configurations by namespace is necessary. Import, would need to use composite identifier of namespace and configuration ID (which is globally unique) adding complexity to the provider. Copy configuration can be easily recreated without negative side effects making import non-critical.

Relations

Closes #36808

References

CreateSnapshotCopyConfiguration in Redshift Serverless API
ListSnapshotCopyConfigurations
UpdateSnapshotCopyConfiguration
DeleteSnapshotCopyConfiguration
Working with snapshots and recovery points

Output from Acceptance Testing

make testacc TESTS=TestAccRedshiftServerlessSnapshotCopyConfiguration PKG=redshiftserverless

Copy link

github-actions bot commented Apr 9, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/redshiftserverless Issues and PRs that pertain to the redshiftserverless service. size/XL Managed by automation to categorize the size of a PR. labels Apr 9, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 9, 2024
@marcinbelczewski marcinbelczewski force-pushed the f-aws_redshiftserverless_snapshot_copy_configuration branch 3 times, most recently from 8131529 to 01f468c Compare April 9, 2024 17:57
@marcinbelczewski marcinbelczewski marked this pull request as ready for review April 9, 2024 18:36
@marcinbelczewski marcinbelczewski marked this pull request as draft April 9, 2024 18:37
@marcinbelczewski marcinbelczewski force-pushed the f-aws_redshiftserverless_snapshot_copy_configuration branch from 01f468c to 86868e8 Compare April 9, 2024 18:39
@marcinbelczewski marcinbelczewski marked this pull request as ready for review April 9, 2024 18:40
@marcinbelczewski marcinbelczewski marked this pull request as draft April 10, 2024 09:18
@marcinbelczewski marcinbelczewski marked this pull request as ready for review April 10, 2024 09:18
@marcinbelczewski marcinbelczewski force-pushed the f-aws_redshiftserverless_snapshot_copy_configuration branch from 86868e8 to 6f9d4aa Compare April 10, 2024 09:43
@marcinbelczewski marcinbelczewski marked this pull request as draft April 10, 2024 17:26
@marcinbelczewski marcinbelczewski force-pushed the f-aws_redshiftserverless_snapshot_copy_configuration branch from 6f9d4aa to 25d3683 Compare April 10, 2024 19:11
@marcinbelczewski marcinbelczewski force-pushed the f-aws_redshiftserverless_snapshot_copy_configuration branch from 25d3683 to a867234 Compare April 10, 2024 19:24
@marcinbelczewski marcinbelczewski marked this pull request as ready for review April 10, 2024 20:07
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. service/redshiftserverless Issues and PRs that pertain to the redshiftserverless service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NewResource]: Add support to create/update/delete snapshot copy configuration for Amazon Redshift Serverless
2 participants