-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_redshiftserverless_snapshot_copy_configuration: implement new resource #36809
Open
marcinbelczewski
wants to merge
1
commit into
hashicorp:main
Choose a base branch
from
marcinbelczewski:f-aws_redshiftserverless_snapshot_copy_configuration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
r/aws_redshiftserverless_snapshot_copy_configuration: implement new resource #36809
marcinbelczewski
wants to merge
1
commit into
hashicorp:main
from
marcinbelczewski:f-aws_redshiftserverless_snapshot_copy_configuration
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
documentation
Introduces or discusses updates to documentation.
tests
PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
generators
Relates to code generators.
service/redshiftserverless
Issues and PRs that pertain to the redshiftserverless service.
size/XL
Managed by automation to categorize the size of a PR.
labels
Apr 9, 2024
terraform-aws-provider
bot
added
the
needs-triage
Waiting for first response or review from a maintainer.
label
Apr 9, 2024
marcinbelczewski
force-pushed
the
f-aws_redshiftserverless_snapshot_copy_configuration
branch
3 times, most recently
from
April 9, 2024 17:57
8131529
to
01f468c
Compare
marcinbelczewski
force-pushed
the
f-aws_redshiftserverless_snapshot_copy_configuration
branch
from
April 9, 2024 18:39
01f468c
to
86868e8
Compare
marcinbelczewski
force-pushed
the
f-aws_redshiftserverless_snapshot_copy_configuration
branch
from
April 10, 2024 09:43
86868e8
to
6f9d4aa
Compare
marcinbelczewski
force-pushed
the
f-aws_redshiftserverless_snapshot_copy_configuration
branch
from
April 10, 2024 19:11
6f9d4aa
to
25d3683
Compare
marcinbelczewski
force-pushed
the
f-aws_redshiftserverless_snapshot_copy_configuration
branch
from
April 10, 2024 19:24
25d3683
to
a867234
Compare
justinretzolk
added
new-resource
Introduces a new resource.
and removed
needs-triage
Waiting for first response or review from a maintainer.
labels
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Introduces or discusses updates to documentation.
generators
Relates to code generators.
new-resource
Introduces a new resource.
service/redshiftserverless
Issues and PRs that pertain to the redshiftserverless service.
size/XL
Managed by automation to categorize the size of a PR.
tests
PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements aws_redshiftserverless_snapshot_copy_configuration to configure copying of Amazon Redshift Serverless snapshots and recovery points to another region.
This PR does not implement importing resource. This is because Redshift Serverless API misses get-snapshot-copy-configuration action preventing direct get via snapshot copy configuration ID and rather listing all configurations by namespace is necessary. Import, would need to use composite identifier of namespace and configuration ID (which is globally unique) adding complexity to the provider. Copy configuration can be easily recreated without negative side effects making import non-critical.
Relations
Closes #36808
References
CreateSnapshotCopyConfiguration in Redshift Serverless API
ListSnapshotCopyConfigurations
UpdateSnapshotCopyConfiguration
DeleteSnapshotCopyConfiguration
Working with snapshots and recovery points
Output from Acceptance Testing
make testacc TESTS=TestAccRedshiftServerlessSnapshotCopyConfiguration PKG=redshiftserverless