-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
b-aws sagemaker feature group #36814
Open
nikhil-goenka
wants to merge
3
commits into
hashicorp:main
Choose a base branch
from
nikhil-goenka:b-aws_sagemaker_feature_group
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
b-aws sagemaker feature group #36814
nikhil-goenka
wants to merge
3
commits into
hashicorp:main
from
nikhil-goenka:b-aws_sagemaker_feature_group
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikhil-goenka
changed the title
B aws sagemaker feature group
b-aws sagemaker feature group
Apr 9, 2024
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
size/S
Managed by automation to categorize the size of a PR.
tests
PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
service/sagemaker
Issues and PRs that pertain to the sagemaker service.
labels
Apr 9, 2024
terraform-aws-provider
bot
added
the
needs-triage
Waiting for first response or review from a maintainer.
label
Apr 9, 2024
justinretzolk
added
bug
Addresses a defect in current functionality.
and removed
needs-triage
Waiting for first response or review from a maintainer.
labels
Apr 15, 2024
@@ -78,7 +76,6 @@ func ResourceFeatureGroup() *schema.Resource { | |||
"feature_type": { | |||
Type: schema.TypeString, | |||
Optional: true, | |||
ForceNew: true, | |||
ValidateFunc: validation.StringInSlice(sagemaker.FeatureType_Values(), false), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nikhil-goenka There is no update function defined inside feature group update to allow this.
You would need add an update block similar to -
input := &sagemaker.CreateFeatureGroupInput{ |
Go SDK https://docs.aws.amazon.com/sdk-for-go/api/service/sagemaker/#UpdateFeatureGroupInput
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Addresses a defect in current functionality.
service/sagemaker
Issues and PRs that pertain to the sagemaker service.
size/S
Managed by automation to categorize the size of a PR.
tests
PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relations
Closes #36784
References
Output from Acceptance Testing