Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

b-aws sagemaker feature group #36814

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

nikhil-goenka
Copy link
Contributor

Description

Relations

Closes #36784

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

@nikhil-goenka nikhil-goenka changed the title B aws sagemaker feature group b-aws sagemaker feature group Apr 9, 2024
Copy link

github-actions bot commented Apr 9, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/sagemaker Issues and PRs that pertain to the sagemaker service. labels Apr 9, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 9, 2024
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 15, 2024
@@ -78,7 +76,6 @@ func ResourceFeatureGroup() *schema.Resource {
"feature_type": {
Type: schema.TypeString,
Optional: true,
ForceNew: true,
ValidateFunc: validation.StringInSlice(sagemaker.FeatureType_Values(), false),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nikhil-goenka There is no update function defined inside feature group update to allow this.
You would need add an update block similar to -

input := &sagemaker.CreateFeatureGroupInput{

Go SDK https://docs.aws.amazon.com/sdk-for-go/api/service/sagemaker/#UpdateFeatureGroupInput

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Addresses a defect in current functionality. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Adding a new feature to an existing feature group causes the feature group to be replaced
3 participants