Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

f-aws_rds_cluster_instance: new data source #36899

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bobbyiliev
Copy link

@bobbyiliev bobbyiliev commented Apr 13, 2024

Description

Here’s a suggested description for your pull request to add the new RDS cluster instance data source:


This data source provides Terraform users with the ability to manage and retrieve detailed information about an Amazon RDS cluster instance. This will aid in the configuration and management of RDS cluster instances, supporting use cases where users need to obtain data dynamically based on instance identifiers without managing the instance itself.

The addition of aws_rds_cluster_instance as a standalone data source aligns with best practices for modular and decoupled Terraform configurations, enabling users to reference RDS cluster instance details in other parts of their Terraform projects independently of instance management.

This data source includes comprehensive attribute support, mirroring that available in the aws_rds_cluster_instance resource, thus ensuring consistency across Terraform configurations and facilitating a smoother integration with existing modules that manage RDS cluster resources.

Relations

Relates #9739

References

Output from Acceptance Testing

% make testacc TESTS=TestAccDataSourceClusterInstance_basic PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccDataSourceClusterInstance_basic'  -timeout 360m
=== RUN   TestAccDataSourceClusterInstance_basic
=== PAUSE TestAccDataSourceClusterInstance_basic
=== CONT  TestAccDataSourceClusterInstance_basic
--- PASS: TestAccDataSourceClusterInstance_basic (1554.50s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rds        1560.592s
...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/rds Issues and PRs that pertain to the rds service. generators Relates to code generators. labels Apr 13, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 13, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @bobbyiliev 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@bobbyiliev bobbyiliev marked this pull request as ready for review April 13, 2024 17:27
@justinretzolk justinretzolk added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-data-source Introduces a new data source. service/rds Issues and PRs that pertain to the rds service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants