Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data.azuread_user[s] - use equals insteadof startsWith when finding users by mailNickname #251

Merged
merged 1 commit into from
May 15, 2020

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented May 15, 2020

fixes #237

@katbyte katbyte added this to the v0.9.0 milestone May 15, 2020
@ghost ghost added the size/XS label May 15, 2020
@katbyte katbyte requested a review from a team May 15, 2020 03:53
Copy link

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@katbyte katbyte merged commit acecad5 into master May 15, 2020
@katbyte katbyte deleted the kt/ds-user-mail-should-not-start-with branch May 15, 2020 04:23
katbyte added a commit that referenced this pull request May 15, 2020
@ghost
Copy link

ghost commented May 15, 2020

This has been released in version 0.9.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azuread" {
    version = "~> 0.9.0"
}
# ... other configuration ...

@Console32
Copy link

This undoes #161 , Is there any other way to get the functionality from #161 into the provider?

@patrickmarabeas
Copy link
Contributor

@Console32 How about a second query - something along the lines of fmt.Sprintf("mailNickname eq '%s#EXT#'", mailNickname) - if no user is returned from the first?

cc @katbyte

@Console32
Copy link

@patrickmarabeas It is not possible to use eq like this I think. The mail nickname is constructed in the following layout afaik: Thats why startsWith did work.

mailNickname_DOMAIN#EXT#

@ghost
Copy link

ghost commented Jun 14, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

data.azuread_user mail_nickname does not use equals filter
4 participants