Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for customer-managed encryption keys (CMEK) for Cloud Run #10213

Closed
framilocvt opened this issue Oct 1, 2021 · 3 comments
Closed
Assignees
Milestone

Comments

@framilocvt
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Please add the recent CMEK feature onto Google Cloud Run Terraform. google_cloud_run_service

Currently the only way to implement this feature is via the GCP portal, which is a problem if you have this type of resource already deployed via IaC.

One of the greatest products that GCP provides to it's customers, and another reason to keep using Terraform for multi-cloud encivironment, make it even more the standard tool for Infrastructure IaC.

New or Affected Resource(s)

GCP Cloud Run

  • google_cloud_run_service CMEK container images protection

Potential Terraform Configuration

# Propose what you think the configuration to take advantage of this feature should look like.
# We may not use it verbatim, but it's helpful in understanding your intent.

References

@rileykarson rileykarson added this to the Goals milestone Oct 4, 2021
@upodroid
Copy link
Contributor

@megan07 megan07 self-assigned this Jul 25, 2022
@megan07
Copy link
Contributor

megan07 commented Jul 26, 2022

Closing given the comment above, this can be set in the annotations block.

@megan07 megan07 closed this as completed Jul 26, 2022
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants