Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] Fix media blocks updates in hub #244

Merged
merged 2 commits into from
Feb 1, 2022
Merged

Conversation

akash-joshi
Copy link
Contributor

@akash-joshi akash-joshi commented Jan 31, 2022

🌟 What is the purpose of this PR?

In the present demo for media blocks in the blocks hub, the media blocks appear to be working fine on first render. However, on clicking the editing pencil, one quickly realizes the blocks update don't work, which I have traced back to the UI rendering condition I've updated in this PR.

As a part of this PR, users will be able to update the media blocks as easily as they do so in the HASH app.

🔍 What does this change?

🔗 Related links

❓ How to test this?

  • Pass a default URL to either video or image blocks in local dev
  • Try clicking on edit icon, the upload form should pop up.

@github-actions github-actions bot added the area/blocks Relates to first-party blocks (area) label Jan 31, 2022
@akash-joshi akash-joshi marked this pull request as ready for review January 31, 2022 09:44
@akash-joshi akash-joshi enabled auto-merge (squash) February 1, 2022 07:00
@akash-joshi akash-joshi merged commit 007b451 into main Feb 1, 2022
@akash-joshi akash-joshi deleted the aj/fix-media-hub-editing branch February 1, 2022 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/blocks Relates to first-party blocks (area)
Development

Successfully merging this pull request may close these issues.

2 participants