Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEN-77: Bump error-stack to 0.4 #2967

Merged
merged 3 commits into from
Aug 23, 2023
Merged

Conversation

TimDiekmann
Copy link
Member

@TimDiekmann TimDiekmann commented Aug 23, 2023

🌟 What is the purpose of this PR?

With the latest nightly change it's required to set a git dependency for error-stack if a nightly compiler is used.

🔍 What does this change?

  • Bump version of error-stack to 0.4.0
  • Adjust changelog to point to the upcoming release tag
  • error-stack@0.3.1 does not compile on the current nightly channel (the main reason for this release), so the SemVer check cannot pass. I temporarily disabled it. I will enable it again after this PR is merged.

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • modifies a Cargo-publishable library and I have amended the version

📜 Does this require a change to the docs?

The changes in this PR:

  • require changes to docs which are made as part of this PR

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

  • do not affect the execution graph

@TimDiekmann TimDiekmann requested a review from a team as a code owner August 23, 2023 07:47
@github-actions github-actions bot added area/infra Relates to version control, CI, CD or IaC (area) area/libs > error-stack Affects the `error-stack` crate (library) area/libs Relates to first-party libraries/crates/packages (area) labels Aug 23, 2023
Copy link
Member

@indietyp indietyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@TimDiekmann TimDiekmann added this pull request to the merge queue Aug 23, 2023
Merged via the queue into main with commit 12017c4 Aug 23, 2023
49 checks passed
@TimDiekmann TimDiekmann deleted the td/gen-77-release-error-stack-04 branch August 23, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/infra Relates to version control, CI, CD or IaC (area) area/libs > error-stack Affects the `error-stack` crate (library) area/libs Relates to first-party libraries/crates/packages (area)
Development

Successfully merging this pull request may close these issues.

2 participants