Is "version" in lsp response used to assure file consistency (e.g. for renames)?

[codygman]

The context is mostly from joaotavora/eglot#1051 (comment) which says:

Probably sending the :version isn't even necessary and Eglot will not perform the check if it isn't present. But if you are the server are going to send one, Eglot assumes its purpose is to assure file consistency and will refuse to perform the edit.

In response to an issue where the user tries to execute a rename and nothing seems to change in emacs with eglot.

[michaelpj]

This is unclear. It's handled in lsp mostly, to be honest I'm not 100% sure how it works, so someone would need to take a look.

[jameschensmith]

I believe the issue is at Ide.PluginUtils#L173 ((Just 0) in (J.VersionedTextDocumentIdentifier f (Just 0))). This is my first time going through Haskell code, but by going through Ide.Plugin.Rename I was able to arrive at Ide.PluginUtils. It looks like version is either always 0, or it defaults to 0 if there is no version passed by the client. Hope this helps!

[July541]

@jameschensmith Thanks for pointing it out! I agree with you, and there is an ongoing pr for both this and #3547.

[maralorn]

This should be fixed by the just merged #3643, maybe you can test this with master or the next hls release, when that happens.

[michaelpj]

I'm going to tentatively mark this as fixed, please reopen if it recurs after the next release.