Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate extension for cabal files only if the used hls version supports it #418

Closed
jneira opened this issue Jul 30, 2021 · 2 comments
Closed
Labels
type: enhancement An enhancement to an already existing feature type: setup Issues related with the extension setup, including binaries downloads

Comments

@jneira
Copy link
Member

jneira commented Jul 30, 2021

@jneira
Copy link
Member Author

jneira commented Aug 3, 2021

Hmm you are rigth, thanks for noting it. Could we do some change in the hls part (or the extension) to avoid those errors? To investigate.
Will do a release without this change in the meanwhile.

I think we can check in the vscode plugin for the version of the hls and hls-wrapper version to launch and conditionally enable loading of cabal files.

@fendor that is a good solution but it would apply only to some version of the vscode extension and not for other editors (so they will have those errors for older hls versions if they enable them like here)
So not sure if it worths look for a solution in hls, where those errors will start to be emitted.

@jneira jneira added type: enhancement An enhancement to an already existing feature type: setup Issues related with the extension setup, including binaries downloads labels Aug 3, 2021
@jneira
Copy link
Member Author

jneira commented Aug 25, 2021

I've reverted the tracking of .cabal files temporary in #444 (91e9738)

@jneira jneira closed this as completed Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement An enhancement to an already existing feature type: setup Issues related with the extension setup, including binaries downloads
Projects
None yet
Development

No branches or pull requests

1 participant