Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪲 saving programs consistently #5510

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

🪲 saving programs consistently #5510

wants to merge 1 commit into from

Conversation

hasan-sh
Copy link
Collaborator

@hasan-sh hasan-sh commented May 8, 2024 •
edited
Loading

Fixes #5507

@jpelay
Copy link
Member

jpelay commented May 9, 2024

Hi! I've been testing and, yes now the programs seem to be being saved more consistently. This is how a saved program from this page looks in the database:

    {
      "session": "fac24066d19f4fd8ac44508ac4a7fdae",
      "date": 1715266264375,
      "lang": "en",
      "version": "DEV",
      "level": 17,
      "code": "print 'hello' 1 + 2",
      "name": "Tik Tak Toe",
      "username": "teacher1",
      "error": false,
      "adventure_name": "Tik Tak Toe",
      "id": "720bcbb290384d7b9f5a018d168c8707",
      "username_level": "teacher1-17",
      "is_modified": true
    }

But I wonder if this is the solution? I think perhaps the best way is to not store programs in this page? I think we should only be storing programs that come from the /hedy page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Hedy organization board
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🪲 Trying a public adventure in the editor, saves the program
2 participants
@hasan-sh @jpelay