Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📜 Remove unnecessary double backticks from translation files #5629

Merged
merged 1 commit into from
Jun 25, 2024
Merged

📜 Remove unnecessary double backticks from translation files #5629

merged 1 commit into from
Jun 25, 2024

Conversation

boryanagoncharenko
Copy link
Collaborator

Maybe fixes #5566

Double backticks are displayed to the end user, which is incorrect. The string `{at}``{random}` should be displayed as at random but appears as at``random. This PR addresses all occurrences of double backticks.

How to test

  • Navigate to level 3 and select the Quiz tab. Change the language to Chinese simplified. Start the quiz and ensure that the value in answer 4 does not contain any backticks.
  • Navigate to level 3 and select the Dishes adventure. Change the language to Spanish. Check that in the description of the adventure the keywords borrar de does not contain backticks.

jpelay
jpelay approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@jpelay jpelay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 25, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 76e1701 into main Jun 25, 2024
12 checks passed
@mergify mergify bot deleted the translations_5566 branch June 25, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpelay jpelay jpelay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Hedy organization board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🪲 levels->3->1->mp_choice_options->[3]->option chinese version not work
2 participants
@boryanagoncharenko @jpelay