Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-Complete adds double $ character after choosing a value from the dropdown menu #11470

Closed
leo-unglaub opened this issue Aug 12, 2024 · 2 comments
Labels
C-bug Category: This is a bug R-duplicate Duplicated issue: please refer to the linked issue

Comments

@leo-unglaub
Copy link

leo-unglaub commented Aug 12, 2024

Summary

Hey,
when you use Helix in a PHP project the LSP autocompletion via phpactor is triggered as soon as you type the $ character. Then you get a list of variable names and so on. As soon as you choose one via <Tab>+<Enter> or via <C-n>+<Enter> it gets added, but with two $ characters.

Expected:

public function client(): BelongsTo
{
	return $this->belongsTo(Device::class);
}

What you end up with:

public function client(): BelongsTo
{
	return $$this->belongsTo(Device::class);
}

Reproduction Steps

No response

Helix log

~/.cache/helix/helix.log
2024-08-12T15:02:50.594 helix_lsp::transport [ERROR] phpactor err <- "Starting language server, use -vvv for verbose output\n"

Platform

Linux desktop 6.10.3-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.10.3-1 (2024-08-04) x86_64 GNU/Linux

Terminal Emulator

GNOME Terminal - Version 3.52.2 for GNOME 46 (VTE version 0.77.91 +BIDI +GNUTLS +ICU +SYSTEMD)

Installation Method

Binary from the release page

Helix Version

helix 24.7 (079f544)

@leo-unglaub leo-unglaub added the C-bug Category: This is a bug label Aug 12, 2024
@VasilisManol
Copy link

VasilisManol commented Aug 22, 2024

Workaround in #9303 (comment)

@kirawi
Copy link
Member

kirawi commented Aug 27, 2024

I'm closing this as a duplicate and since it has a solution.

@kirawi kirawi closed this as not planned Won't fix, can't repro, duplicate, stale Aug 27, 2024
@kirawi kirawi added the R-duplicate Duplicated issue: please refer to the linked issue label Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug R-duplicate Duplicated issue: please refer to the linked issue
Projects
None yet
Development

No branches or pull requests

3 participants