Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMP like Jump Mode #510

Closed
yerlaser opened this issue Jul 26, 2021 · 9 comments · Fixed by #8875
Closed

AMP like Jump Mode #510

yerlaser opened this issue Jul 26, 2021 · 9 comments · Fixed by #8875
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements

Comments

@yerlaser
Copy link
Contributor

Amp Editor (https://amp.rs/docs/usage/) has a very sweet jump mode.
Since it's also written in Rust and open source, would it be a crime to suggest to peek into the code and steal some ideas from it?

@yerlaser yerlaser added the C-enhancement Category: Improvements label Jul 26, 2021
@sudormrfbin
Copy link
Member

Previous discussion: #274

@kirawi kirawi added the A-helix-term Area: Helix term improvements label Aug 19, 2021
@yerlaser yerlaser changed the title AMP like easymotion AMP like Jump Mode Aug 31, 2021
@yerlaser
Copy link
Contributor Author

Thanks, yes, it's related, but I would still keep this open because:

  1. AMP's jump mode is different than the likes of EasyMotion and AceJump. In AMP, you don't need to type search character before highlighting appears. Once the shortcut is pressed, all visible words are highlighted with two character tags. User then needs to type the needed tag and jump to that position. So, this is one step shorter and it makes a big difference really. It's so fast and becomes so natural that one almost forgets about other ways to navigate code.

  2. Since AMP is written in Rust and open source, certain ideas could potentially be easier to port than other solutions.

@MartinDrees
Copy link

I think that it is also worth it to take a look at avy. It is an improved AceJump for emacs with better customization.

@txtyash
Copy link
Contributor

txtyash commented Jun 19, 2022

hop.nvim built-in 🔥

@Omnikar Omnikar mentioned this issue Sep 11, 2022
3 tasks
@clord
Copy link

clord commented Feb 28, 2023

Last time I gave helix a solid chance, a good jump mechanism like hop.vim was all I really missed.

It'd be even better to have a jump-to-treesitter-node mode that can visually jump to significant types of nodes, like parents, siblings, and children. Usually my eye is already where I want to go, so being able to bring up a two-char jump code is killer. Maybe a jump mode with all of these navigations 🤔

@jabbalaci
Copy link

What is the status of this enhancement idea? This thing is awesome in Amp, I'd love to see it in Helix too.

@yerlaser
Copy link
Contributor Author

There are two pull requests with differing implementations, but they are not being reviewed for some reason :(

@dead10ck
Copy link
Member

The maintainers only have so much spare time. We have to prioritize. You may notice, as of this writing, there are 283 pull requests open

@yerlaser
Copy link
Contributor Author

I know, and I respect that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants